Re: Please revert 928bea964827d7824b548c1f8e06eccbbc4d0d7d
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2013-09-27 21:47:06
Also in:
linux-pci, lkml
On Fri, 2013-09-27 at 10:10 -0700, Linus Torvalds wrote:
quoted
So i would like to use the first way that you suggest : call pci_set_master PCIe port driver.So I have to say, that if we can fix this with just adding a single new pci_set_master() call, we should do that before we decide to revert. If other, bigger issues then come up, we can decide to revert. But if there's a one-liner fix, let's just do that first, ok? Mind sending a patch?
Wouldn't it be better to simply have pci_enable_device() always set bus master on a bridge? I don't see any case where it makes sense to have an enabled bridge without the master bit set on it... Cheers, Ben.