Re: [alsa-devel] [PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver

Hi Stephen,

I have a whole changelist in the cover letter (PATCH 0/2). Please take a
look at it.

And about the codec dummy things.. I do that only because the codec
driver's doc say so.

Thank you,
Nicolin


On Wed, Aug 21, 2013 at 12:17 AM, Stephen Warren [off-list ref]wrote:

On 08/19/2013 10:32 PM, Nicolin Chen wrote:

quoted

This patch implements a device-tree-only machine driver for Freescale
i.MX series Soc. It works with spdif_transmitter/spdif_receiver and
fsl_spdif.c drivers.

Signed-off-by: Nicolin Chen <redacted>
---
 .../devicetree/bindings/sound/imx-audio-spdif.txt  |   29 +++++

What changed between v8 and v9?

quoted

diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt

b/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt

quoted

+Optional properties:
+
+  - spdif-transmitter : The phandle of the spdif-transmitter dummy codec
+
+  - spdif-receiver : The phandle of the spdif-receiver dummy codec
+
+* Note: At least one of these two properties should be set in the DT

binding.

I still don't think "dummy CODEC" is an appropriate thing to have in DT.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel