Thread (4 messages) 4 messages, 2 authors, 2013-08-12

Re: [PATCH 1/2] powerpc: Pull out cpu_core_mask updates into a separate function

flat view

From: Stephen Rothwell <hidden>
Date: 2013-08-12 04:41:05

Hi Paul,

On Sat, 10 Aug 2013 13:45:30 +1000 Paul Mackerras [off-list ref] wrote:
quoted hunk ↗ jump to hunk
This factors out the details of updating cpu_core_mask into a separate
function, to make it easier to change how the mask is calculated later.
This makes no functional change.

Signed-off-by: Paul Mackerras <redacted>
---
 arch/powerpc/kernel/smp.c | 56 +++++++++++++++++++++++------------------------
 1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
index 38b0ba6..663cefd 100644
--- a/arch/powerpc/kernel/smp.c
+++ b/arch/powerpc/kernel/smp.c
@@ -609,11 +609,36 @@ static struct device_node *cpu_to_l2cache(int cpu)
 	return cache;
 }
 
+static void traverse_core_siblings(int cpu, int add)
This "add" parameter is only used as a boolean, so should be declared
that way.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help