Thread (37 messages) 37 messages, 6 authors, 2013-08-24

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

From: Tomasz Figa <hidden>
Date: 2013-08-17 15:13:25
Also in: alsa-devel, linux-devicetree

On Saturday 17 of August 2013 17:00:02 Sascha Hauer wrote:
On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote:
quoted
quoted
You mean tx<0-7>.

Also I would make this option required. Use a dummy clock for mux
inputs that are grounded for a specific SoC.
Why do you need a dummy clock?

The driver can simply try to grab all the possible clocks and discard
those that failed, so you can just keep those grounded clocks
unspecified.
We don't need dummy clocks. My motivation saying this that I was afraid
people try to configure the driver by skipping the clocks they don't
want from the devicetree.
I'm not really sure if the same abuse couldn't be easily achieved by 
putting dummy clocks in place of those skipped clocks.

Adding a note in binding documentation that says that all clocks that are 
fed to the IP shall be specified should be fine IMHO.

Best regards,
Tomasz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help