Re: [PATCH v7 1/3] DMA: Freescale: revise device tree binding document
flat view
From: Stephen Warren <hidden>
Date: 2013-08-21 22:33:22
Also in:
linux-devicetree, lkml
On 07/29/2013 04:49 AM, hongbo.zhang@freescale.com wrote:
From: Hongbo Zhang <redacted> This patch updates the discription of each type of DMA controller and its channels, it is preparation for adding another new DMA controller binding, it also fixes some defects of indent for text alignment at the same time.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt b/Documentation/devicetree/bindings/powerpc/fsl/dma.txt
quoted hunk ↗ jump to hunk
-- compatible : compatible list, contains 2 entries, first is - "fsl,CHIP-dma", where CHIP is the processor - (mpc8349, mpc8360, etc.) and the second is - "fsl,elo-dma" +- compatible : must include "fsl,elo-dma"
Why remove the list of supported compatible values. Lately it seems that
we're moving towards listing more/all the values rather than removing
their documentation...
quoted hunk ↗ jump to hunk
-- ranges : Should be defined as specified in 1) to describe the - DMA controller channels. +- ranges : describes the mapping between the address space of the + DMA channels and the address space of the DMA controller
What is "the address space of the DMA controller". Perhaps this should
say "the CPU-visible address space" instead?