[ devicetree@vger adjusted ]
On Mon, Jul 22, 2013 at 15:09 +0100, Mark Brown wrote:
On Mon, Jul 22, 2013 at 02:14:28PM +0200, Gerhard Sittig wrote:
quoted
+ ret = clk_prepare_enable(clk);
+ if (ret) {
+ devm_clk_put(dev, clk);
+ goto free_irq;
The main point of the devm_ APIs is to avoid the need for explicit
freeing so you should just remove these puts.
OK, will do in v4.
Shall these get removed everywhere including regular shutdown
paths, or just from error paths during setup?
[ the same topic came up for the CAN patch, might answer there ]
virtually yours
Gerhard Sittig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office@denx.de