Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability
From: Sascha Hauer <s.hauer@pengutronix.de>
Date: 2013-07-15 19:38:29
Also in:
linux-arm-kernel, linux-devicetree
Possibly related (same subject, not in this thread)
- 2013-08-02 · Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability · Mike Turquette <hidden>
- 2013-07-18 · Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability · Nicolas Pitre <hidden>
- 2013-07-18 · Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability · Mark Brown <hidden>
- 2013-07-18 · Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability · Russell King - ARM Linux <hidden>
On Mon, Jul 15, 2013 at 08:47:34PM +0200, Gerhard Sittig wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/clk/clk-divider.c b/drivers/clk/clk-divider.c index 6d55eb2..2c07061 100644 --- a/drivers/clk/clk-divider.c +++ b/drivers/clk/clk-divider.c@@ -104,7 +104,7 @@ static unsigned long clk_divider_recalc_rate(struct clk_hw *hw, struct clk_divider *divider = to_clk_divider(hw); unsigned int div, val; - val = readl(divider->reg) >> divider->shift; + val = clk_readl(divider->reg) >> divider->shift; val &= div_mask(divider);
Would it be an option to use regmap for the generic dividers/muxes instead? This should be suitable for ppc and also for people who want to use the generic clocks on i2c devices. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |