Thread (4 messages) 4 messages, 2 authors, 2013-06-25

Re: [PATCH 2/2] powerpc/hw_brk: Fix clearing of extraneous IRQ

From: Anshuman Khandual <hidden>
Date: 2013-06-25 09:00:50

On 06/24/2013 11:17 AM, Michael Neuling wrote:
In 9422de3 "powerpc: Hardware breakpoints rewrite to handle non DABR breakpoint
registers" we changed the way we mark extraneous irqs with this:

-	info->extraneous_interrupt = !((bp->attr.bp_addr <= dar) &&
-			(dar - bp->attr.bp_addr < bp->attr.bp_len));
+	if (!((bp->attr.bp_addr <= dar) &&
+	      (dar - bp->attr.bp_addr < bp->attr.bp_len)))
+		info->type |= HW_BRK_TYPE_EXTRANEOUS_IRQ;

Unfortunately this is bogus as it never clears extraneous IRQ if it's already
set.

This correctly clears extraneous IRQ before possibly setting it.

Signed-off-by: Michael Neuling <redacted>
Reviewed-by: Anshuman Khandual <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help