On Mon, Jun 24, 2013 at 12:18:04PM -0500, Seth Jennings wrote:

On Mon, Jun 24, 2013 at 09:14:23AM -0500, Nathan Fontenot wrote:

quoted

The topology update code that updates the cpu node registration in sysfs
should not be called while in stop_machine(). The register/unregister
calls take a lock and may sleep.

This patch moves these calls outside of the call to stop_machine().

Signed-off-by:Nathan Fontenot [off-list ref]

Reviewed-by: Seth Jennings <redacted>

Gah! I _knew_ I should have waited for my cross compiler to finish
building.  This thing doesn't build:

  CC      arch/powerpc/mm/numa.o
/home/sjennings/ltc/linux/arch/powerpc/mm/numa.c: In function 'arch_update_cpu_topology':
/home/sjennings/ltc/linux/arch/powerpc/mm/numa.c:1486: error: 'update' undeclared (first use in this function)
/home/sjennings/ltc/linux/arch/powerpc/mm/numa.c:1486: error: (Each undeclared identifier is reported only once
/home/sjennings/ltc/linux/arch/powerpc/mm/numa.c:1486: error: for each function it appears in.)

s/update/ud/ in the *_cpu_under_node() calls.

Seth