Thread (3 messages) flat view 3 messages, 2 authors, 2013-06-04

Re: [PATCH] powerpc/perf: Fix deadlock caused by calling printk() in PMU exception

From: Michael Ellerman <hidden>
Date: 2013-06-04 09:50:32

On Tue, 2013-06-04 at 14:35 +0530, Anshuman Khandual wrote:
quoted
+	seq_printf(p, "%*s: ", prec, "PMS");
Lets make this PMIS or PMI_S instead of PMS.
Everything else is aligned using a three character prefix, so that would
stuff the alignment up.
quoted
+	for_each_online_cpu(j)
+		seq_printf(p, "%10u ", per_cpu(irq_stat, j).pmu_irqs);
This would be pmu_spurious_irqs instead of pmu_irqs.
Yep, thanks for reviewing.

I'm actually thinking I'll drop the counter, at least until we can be
sure it's not us causing the spurious interrupts.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help