Re: [PATCH 3/8] vfio: add external user support
From: Stephen Rothwell <hidden>
Date: 2013-06-27 06:59:42
Also in:
kvm, lkml
Hi Alexy, On Thu, 27 Jun 2013 15:02:31 +1000 Alexey Kardashevskiy [off-list ref] wrote:
quoted hunk ↗ jump to hunk
+/* Allows an external user (for example, KVM) to unlock an IOMMU group */ +static void vfio_group_del_external_user(struct file *filep) +{ + struct vfio_group *group = filep->private_data; + + BUG_ON(filep->f_op != &vfio_group_fops);
We usually reserve BUG_ON for situations where there is no way to continue running or continuing will corrupt the running kernel. Maybe WARN_ON() and return? -- Cheers, Stephen Rothwell sfr@canb.auug.org.au
Attachments
- (unnamed) [application/pgp-signature] 836 bytes