Re: [PATCH] powerpc/pseries: Enable PSTORE in pseries_defconfig
From: Aruna Balakrishnaiah <hidden>
Date: 2013-06-24 06:43:48
Also in:
lkml
Hi Michael, On Monday 24 June 2013 06:51 AM, Michael Neuling wrote:
quoted
Enable PSTORE in pseries_defconfigPlease add a "why" to your changelogs eg. "Now we have pstore support for nvram on pseries, enable it in the default config" "Why" you are changing something is more important than "what", since you can always determine "what" is being changed, by looking at the diff. The "why" will be long forgotten.quoted
Signed-off-by: Aruna Balakrishnaiah <redacted> --- arch/powerpc/configs/pseries_defconfig | 1 + 1 file changed, 1 insertion(+)diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig index c4dfbaf..9630a50 100644 --- a/arch/powerpc/configs/pseries_defconfig +++ b/arch/powerpc/configs/pseries_defconfig@@ -347,3 +347,4 @@ CONFIG_VIRTUALIZATION=y CONFIG_KVM_BOOK3S_64=m CONFIG_KVM_BOOK3S_64_HV=y CONFIG_VHOST_NET=m +CONFIG_PSTORE=yThis should really be added in the right location on the config, not just at the end. ie.
Sorry, I overlooked this commentin my v2 patch. Will resend.
quoted hunk ↗ jump to hunk
@@ -296,6 +293,7 @@ CONFIG_SQUASHFS_XATTR=y CONFIG_SQUASHFS_LZO=y CONFIG_SQUASHFS_XZ=y +CONFIG_PSTORE=y CONFIG_NFS_FS=y CONFIG_NFS_V3_ACL=y CONFIG_NFS_V4=y_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev