Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

On Mon, Jun 10, 2013 at 10:03 AM, Russell King - ARM Linux
[off-list ref] wrote:

On Mon, Jun 10, 2013 at 01:49:22AM +0100, Grant Likely wrote:

quoted

This is an RFC patch to convert the versatile FPGA irq controller driver
to use generic irq chip. It builds on the series that extends the
generic chip code to allow a linear irq domain to contain one or more
generic irq chips so that each interrupt controller doesn't need to hand
code the generic chip setup.

NAK, this makes functional changes.  You assume that the validity mask is
a set of zeros followed by a set of ones.  This is not always the case.
The PIC on Integrator/CP only has bits 29-22 and 11-0 set because 21-12
are not valid.

Actually, I don't (at least I don't intend to). It chooses the size of
the irq_domain based on fls(), but that is only because the size has
to allocates for both the holes and the active irqs. You'll notice
that gc->unused is set to ~valid, and the generic chip code will
refuse to map in interrupt that isn't supported. If you see something
different, please point out where because that would be a bug.

g.