Re: [PATCH] net: Unbreak compat_sys_{send,recv}msg
From: Eric Dumazet <hidden>
Date: 2013-06-06 13:45:41
Also in:
lkml, netdev
On Thu, 2013-06-06 at 00:26 -0700, David Miller wrote:
From: Andy Lutomirski <luto@amacapital.net> Date: Wed, 5 Jun 2013 22:38:26 -0700quoted
I broke them in this commit: commit 1be374a0518a288147c6a7398792583200a67261 Author: Andy Lutomirski [off-list ref] Date: Wed May 22 14:07:44 2013 -0700 net: Block MSG_CMSG_COMPAT in send(m)msg and recv(m)msg This patch adds __sys_sendmsg and __sys_sendmsg as common helpers that accept MSG_CMSG_COMPAT and blocks MSG_CMSG_COMPAT at the syscall entrypoints. It also reverts some unnecessary checks in sys_socketcall. Apparently I was suffering from underscore blindness the first time around. Signed-off-by: Andy Lutomirski <luto@amacapital.net>Eric, can you test this patch too?
Yes, this fixes the problem as well on x86_64 Tested-by: Eric Dumazet <edumazet@google.com> Thanks ! PS: I had following fuzz while applying on Linus tree : patching file include/linux/socket.h Hunk #1 succeeded at 320 (offset -1 lines). patching file net/compat.c patching file net/socket.c Hunk #1 succeeded at 1956 (offset -22 lines). Hunk #2 succeeded at 2071 (offset -22 lines). Hunk #3 succeeded at 2125 (offset -22 lines). Hunk #4 succeeded at 2163 (offset -22 lines). Hunk #5 succeeded at 2255 (offset -22 lines). Hunk #6 succeeded at 2317 (offset -22 lines). Hunk #7 succeeded at 2515 (offset -20 lines).