Re: [PATCH v5 12/13] ARM: kirkwood: remove redundant DT board files
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Date: 2013-05-30 09:08:32
Also in:
linux-arm-kernel, lkml, netdev
From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Date: 2013-05-30 09:08:32
Also in:
linux-arm-kernel, lkml, netdev
On 05/30/13 11:06, Arnaud Ebalard wrote:
Sebastian Hesselbarth [off-list ref] writes:quoted
With DT support for mv643xx_eth board specific init for some boards now is unneccessary. Remove those board files, Kconfig entries, and corresponding entries in kirkwood_defconfig. Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
...
Just a stupid note: With Thomas ongoing work to get mvebu-pcie driver in place and enabled for kirkwood, some boards setup files will also lose their pcie init routines, which may allow you to kill those additonal files soon. For instance 6bd98481ab34 (arm: kirkwood: NETGEAR ReadyNAS Duo v2 init PCIe via DT) currently sitting in jcooper/mvebu/pcie_kirkwood removes the PCIE init routine in board-readynas.c, and yours remove ge00 init. With both applied, the whole file can go away. AFAICT, this may be the case soon for: arch/arm/mach-kirkwood/board-iconnect.c (36e5722089) arch/arm/mach-kirkwood/board-mplcec4.c (9470fbfb8d) arch/arm/mach-kirkwood/board-nsa310.c (40fa8e5da2) arch/arm/mach-kirkwood/board-readynas.c (6bd98481ab) arch/arm/mach-kirkwood/board-ts219.c (259e234608) Anyway, thanks for this work Sebastian.
Arnaud, I already realized this when merging Jason's recent PRs and put mv643xx_eth patches on top. I am aware of it but as ARM part of mv643xx_eth will be delayed until net part surfaces, we have plenty of time to react on current updates to mach-kirkwood boards. Sebastian