Re: [PATCH 20/21] powerpc/ps3: remove inline marking of EXPORT_SYMBOL functions
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2013-05-17 16:05:27
Also in:
lkml
On Thu, May 9, 2013 at 12:36 PM, Denis Efremov [off-list ref] wrote:
quoted hunk ↗ jump to hunk
EXPORT_SYMBOL and inline directives are contradictory to each other. The patch fixes this inconsistency. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Denis Efremov <redacted> --- arch/powerpc/platforms/ps3/spu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c index e17fa14..a0bca05 100644 --- a/arch/powerpc/platforms/ps3/spu.c +++ b/arch/powerpc/platforms/ps3/spu.c@@ -143,7 +143,7 @@ static void _dump_areas(unsigned int spe_id, unsigned long priv2, pr_debug("%s:%d: shadow: %lxh\n", func, line, shadow); } -inline u64 ps3_get_spe_id(void *arg) +u64 ps3_get_spe_id(void *arg) { return spu_pdata(arg)->spe_id; }
FYI, this symbol is not used in mainline.
IIRC, it's used for profiling only. Any chance the profile code will
ever make it
in mainline?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds