Re: [PATCH v2, part 1 3/9] PCI: Convert alloc_pci_dev(void) to pci_alloc_dev(bus) instead
From: Yinghai Lu <yinghai@kernel.org>
Date: 2013-05-15 14:58:48
Also in:
linux-pci, lkml, sparclinux
On Wed, May 15, 2013 at 7:46 AM, Liu Jiang [off-list ref] wrote:
On Wed 15 May 2013 10:43:02 PM CST, Yinghai Lu wrote:quoted
quoted
that is another bug, let of guy handle it. YinghaiHi Yinghai, I don't know any OF exports, could you please help to CC some OF experts?
powerpc and sparc are using that.
Ben,
in drivers/pci/probe.c::pci_scan_device() there is
pci_set_of_node(dev);
if (pci_setup_device(dev)) {
kfree(dev);
return NULL;
}
so if pci_setup_device fails, there is one dev reference is not release.
please check you can just move down pci_set_of_node down after that
failing path, like
if (pci_setup_device(dev)) {
kfree(dev);
return NULL;
}
pci_set_of_node(dev);
Yinghai