Thread (6 messages) 6 messages, 2 authors, 2013-04-16

Re: [PATCH 1/2] powerpc: remove section changes from _GLOBAL() and friends

From: Michael Ellerman <hidden>
Date: 2013-04-16 08:33:11

On Tue, Apr 16, 2013 at 02:17:47AM +1000, Stephen Rothwell wrote:
Hi Michael,

On Mon, 15 Apr 2013 23:30:40 +1000 Stephen Rothwell [off-list ref] wrote:
quoted
On Mon, 15 Apr 2013 22:00:17 +1000 Michael Ellerman [off-list ref] wrote:
quoted
On Thu, Nov 29, 2012 at 10:55:25AM +1100, Stephen Rothwell wrote:
quoted
These sometimes produce unexpected results and make it hard to put the
start up code (for 64 bit) into the .head.text section.
...
quoted
diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S
index 6f62a73..4ec5625 100644
--- a/arch/powerpc/kernel/head_fsl_booke.S
+++ b/arch/powerpc/kernel/head_fsl_booke.S
@@ -776,6 +776,8 @@ tlb_write_entry:
 	mfspr	r10, SPRN_SPRG_RSCRATCH0
 	rfi					/* Force context change */
 
+	,text
+
I'm assuming this should be .text ?
Indeed.  Oops :-)
BTW, those patches are almost certainly stale by now and would need to be
redone before be included on the kernel proper.
Now you tell me. It's in my tree, and building, but potentially missing
some .text annotations I guess. I'll rip it out until you send me a new
version.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help