RE: [PATCH 1/3] rapidio: make enumeration/discovery configurable

From
Bounine, Alexandre <hidden>
Date
2013-04-29 12:15:22
Also in
lkml
Reply to
Andrew Morton, 2013-04-26
On Fri, 26 Apr 2013 6:53 PM Andrew Morton [off-list ref] wrote=
:
Subject: Re: [PATCH 1/3] rapidio: make enumeration/discovery
configurable
=20
This Kconfig change makes my kbuild do Weird Things.
=20
make mrproper ; yes "" | make allmodconfig ; make 2>/tmp/x
... skip ...=20
:   DMA Engine support for RapidIO (RAPIDIO_DMA_ENGINE) [Y/n/?] y
:   RapidIO subsystem debug messages (RAPIDIO_DEBUG) [Y/n/?] y
:   Enumeration method [M/y/?] (NEW) aborted!
:
: Console input/output is redirected. Run 'make oldconfig' to update conf=
iguration.
quoted hunk ↗ jump to hunk
:
:   SYSHDR  arch/x86/syscalls/../include/generated/uapi/asm/unistd_32.h
:   SYSHDR  arch/x86/syscalls/../include/generated/uapi/asm/unistd_64.h
:   SYSHDR
arch/x86/syscalls/../include/generated/uapi/asm/unistd_x32.h
=20
=20
See the "Enumeration method [M/y/?] (NEW) aborted!"
=20
Note that this only happens when make's stderr is redirected.
=20
I've no idea what's going on here.  This appears to fix things:
=20
--- a/drivers/rapidio/Kconfig~rapidio-make-enumeration-discovery-
configurable-fix
+++ a/drivers/rapidio/Kconfig
@@ -59,7 +59,7 @@ choice
 	  If unsure, select Basic built-in.
=20
 config RAPIDIO_ENUM_BASIC
-	tristate "Basic"
+	bool "Basic"
 	help
 	  This option includes basic RapidIO fabric enumeration and
discovery
 	  mechanism similar to one described in RapidIO specification
Annex 1.
=20
but doesn't appear to be what you intended.
Goal is to build enumerator as a module or built-in.
I will retest v2 of patches for this issue.
There are some changes to Kconfig (removed AUTO_ENUM option).
Thread (8 messages) 8 messages, 2 authors, last reply 2013-04-29
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help