On Tue, Apr 23, 2013 at 06:53:20PM -0500, Scott Wood wrote:

On 04/19/2013 05:47:35 AM, Zhao Chenhui wrote:

quoted

static int pmc_suspend_enter(suspend_state_t state)
{
-	int ret;
+	int ret = 0;
+
+	switch (state) {
+#ifdef CONFIG_PPC_85xx
+	case PM_SUSPEND_MEM:
+#ifdef CONFIG_SPE
+		enable_kernel_spe();
+#endif
+		enable_kernel_fp();

Why does enable_kernel_spe() need an ifdef but enable_kernel_fp()
doesn't?

will enclose it with CONFIG_PPC_FPU.

quoted

+	case PM_SUSPEND_STANDBY:
+#ifdef CONFIG_FSL_SOC_BOOKE
+		flush_dcache_L1();
+#endif
+		setbits32(&pmc_regs->powmgtcsr, POWMGTCSR_SLP);

Only L1, even on e500mc?

-Scott

This patch is just for chips with pmc unit. They have no e500mc core.

-Chenhui