On Fri, Feb 15, 2013 at 03:18:35PM -0800, Doug Anderson wrote:

There is simply no reason to be manually setting the private driver
data to NULL in the remove/fail to probe cases.  This is just extra
cruft code that can be removed.

A few notes:
* Nothing relies on drvdata being set to NULL.
* The __device_release_driver() function eventually calls
  dev_set_drvdata(dev, NULL) anyway, so there's no need to do it
  twice.
* I verified that there were no cases where xxx_get_drvdata() was
  being called in these drivers and checking for / relying on the NULL
  return value.

This could be cleaned up kernel-wide but for now just take the baby
step and remove from the i2c subsystem.

Reported-by: Wolfram Sang <redacted>
Reported-by: Stephen Warren <redacted>
Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 drivers/i2c/busses/i2c-au1550.c             | 1 -
 drivers/i2c/busses/i2c-bfin-twi.c           | 2 --
 drivers/i2c/busses/i2c-cpm.c                | 2 --
 drivers/i2c/busses/i2c-davinci.c            | 2 --
 drivers/i2c/busses/i2c-designware-pcidrv.c  | 2 --
 drivers/i2c/busses/i2c-designware-platdrv.c | 2 --

For i2c-designware-pcidrv.c and i2c-designware-platdrv.c:

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>