On 02/12/2013 09:09 PM, Kumar Gala wrote:

On Feb 4, 2013, at 9:30 AM, Timur Tabi wrote:

quoted

On 02/03/2013 01:39 PM, Stef van Os wrote:

quoted

+	pci0: pci@fe0008000 {
+		status = "disabled";
+	};
+
+	pci1: pci@fe0009000 {
+		status = "disabled";
+	};
+
+	pci2: pcie@fe000a000 {
+		status = "disabled";
+	};

I was hoping you'd follow my example and include a comment indicating why the PCI devices are all disabled.

quoted

+static void ppa8548_show_cpuinfo(struct seq_file *m)
+{
+	uint svid, phid1;

Please don't used unsized integers for hardware registers.

	uint32_t svid, phid1;

Stef,

If you'd like this included for 3.9, please make the minor updates.

thanks

- k

Patches are on their way. Thanks!

Stef.