Re[5]: PS3 platform is broken on Linux 3.7.0
flat view
From: Phileas Fogg <hidden>
Date: 2013-02-10 17:51:45
Phileas Fogg < phileas-fogg@mail.ru > writes:quoted
Please ignore the previous patch to fix the PACA issue on PS3 arch. This is the correct one:--- a/arch/powerpc/kernel/setup_64.c 2013-02-10 13:56:12.803855673 +0100 +++ b/arch/powerpc/kernel/setup_64.c 2013-02-10 14:07:22.870561322 +0100@@ -186,6 +186,9 @@ initialise_paca(&boot_paca, 0); setup_paca(&boot_paca); + /* Allow percpu accesses to "work" until we setup percpu data */ + boot_paca.data_offset = 0; + /* Initialize lockdep early or else spinlocks will blow */ lockdep_init();commit 466921c5a4669f4315528a25f9afd66601ce2c04 is done to fix the lockdep related issue on ppc64. So this may need little bit more explanation. So if we explicitly use boot_paca, do we still need the changes in the above commit ? -aneesh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Ok, here is the next PACA fix test. I tested the following patch with Linux 3.8.0-rc7 on PS3 arch and still getting panics. Patch:
--- arch/powerpc/kernel/setup_64.c.old 2013-02-10 19:34:53.787366191 +0100
+++ arch/powerpc/kernel/setup_64.c 2013-02-10 19:35:38.834035478 +0100@@ -186,6 +186,9 @@initialise_paca(&boot_paca, 0); setup_paca(&boot_paca); + /* Allow percpu accesses to "work" until we setup percpu data */ + boot_paca.data_offset = 0; + /* Initialize lockdep early or else spinlocks will blow */ lockdep_init();
@@ -208,8 +211,6 @@/* Fix up paca fields required for the boot cpu */ get_paca()->cpu_start = 1; - /* Allow percpu accesses to "work" until we setup percpu data */ - get_paca()->data_offset = 0; /* Probe the machine type */ probe_machine(); It seems that 'boot_paca' and 'get_paca()' refer to different PACAs. regards