-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, January 11, 2013 1:19 AM
To: Singh Sandeep-B37400
Cc: Wood Scott-B07421; devicetree-discuss@lists.ozlabs.org; linuxppc-
dev@ozlabs.org; Aggrwal Poonam-B10812
Subject: Re: [PATCH] Added device tree binding for TDM and TDM phy
=20
On 01/10/2013 03:24:21 AM, Singh Sandeep-B37400 wrote:

quoted

quoted

quoted

quoted

+- compatible
+    Value type: <string>
+    Definition: Should contain generic compatibility like

"tdm-phy-slic"

quoted

or
+    "tdm-phy-e1" or "tdm-phy-t1".

Does this "generic" string (plus the other properties) tell you all

you

quoted

need to know about the device?  If there are other possible

"generic"

quoted

compatibles, they should be listed or else different people will

make up

quoted

different strings for the same thing.

This property will describe the type of device, and will help TDM
framework to know if it is E1/T1/SLIC device. Further details can be
extracted from other compatible strings.
There are only three generic compatibles field types, which are
already mentioned in definition. Do I need to make this thing more
clear.

=20
The word "like" suggests that there are other possibilites.  It would be
clearer as:
=20
Definition: One of "tdm-phy-slic", "tdm-phy-e1", or "tdm-phy-t1".
=20
-Scott

Ok, thanks for your comments.