Re: [RFC PATCH v2 01/12] Add sys_hotplug.h for system device hotplug framework
From: Toshi Kani <hidden>
Date: 2013-01-14 19:11:57
Also in:
linux-acpi, linux-mm, linux-s390, lkml
On Mon, 2013-01-14 at 19:48 +0100, Rafael J. Wysocki wrote:
On Monday, January 14, 2013 08:33:48 AM Toshi Kani wrote:quoted
On Fri, 2013-01-11 at 22:23 +0100, Rafael J. Wysocki wrote:quoted
On Thursday, January 10, 2013 04:40:19 PM Toshi Kani wrote:quoted
Added include/linux/sys_hotplug.h, which defines the system device hotplug framework interfaces used by the framework itself and handlers. The order values define the calling sequence of handlers. For add execute, the ordering is ACPI->MEM->CPU. Memory is onlined before CPU so that threads on new CPUs can start using their local memory. The ordering of the delete execute is symmetric to the add execute. struct shp_request defines a hot-plug request information. The device resource information is managed with a list so that a single request may target to multiple devices.:quoted
quoted
+ +struct shp_device { + struct list_head list; + struct device *device; + enum shp_class class; + union shp_dev_info info; +}; + +/* + * Hot-plug request + */ +struct shp_request { + /* common info */ + enum shp_operation operation; /* operation */ + + /* hot-plug event info: only valid for hot-plug operations */ + void *handle; /* FW handle */What's the role of handle here?On ACPI-based platforms, the handle keeps a notified ACPI handle when a hot-plug request is made. ACPI bus handlers, acpi_add_execute() / acpi_del_execute(), then scans / trims ACPI devices from the handle.OK, so this is ACPI-specific and should be described as such.
Other FW interface I know is parisc, which has mod_index (module index) to identify a unique object, just like what ACPI handle does. The handle can keep the mod_index as an opaque value as well. But as you said, I do not know if the handle works for all other FWs. So, I will add descriptions, such that the hot-plug event info is modeled after ACPI and may need to be revisited when supporting other FW. Thanks, -Toshi