Thread (47 messages) 47 messages, 6 authors, 2013-02-07

Re: [PATCH v5 06/14] memory-hotplug: implement register_page_bootmem_info_section of sparse-vmemmap

From: Tang Chen <hidden>
Date: 2012-12-26 03:22:05
Also in: linux-acpi, linux-mm, linux-s390, linux-sh, lkml, sparclinux

On 12/25/2012 04:09 PM, Jianguo Wu wrote:
quoted
+
+		if (!cpu=5Fhas=5Fpse) {
+			next =3D (addr + PAGE=5FSIZE)&  PAGE=5FMASK;
+			pmd =3D pmd=5Foffset(pud, addr);
+			if (pmd=5Fnone(*pmd))
+				continue;
+			get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd),
+					 MIX=5FSECTION=5FINFO);
+
+			pte =3D pte=5Foffset=5Fkernel(pmd, addr);
+			if (pte=5Fnone(*pte))
+				continue;
+			get=5Fpage=5Fbootmem(section=5Fnr, pte=5Fpage(*pte),
+					 SECTION=5FINFO);
+		} else {
+			next =3D pmd=5Faddr=5Fend(addr, end);
+
+			pmd =3D pmd=5Foffset(pud, addr);
+			if (pmd=5Fnone(*pmd))
+				continue;
+			get=5Fpage=5Fbootmem(section=5Fnr, pmd=5Fpage(*pmd),
+					 SECTION=5FINFO);
Hi Tang=EF=BC=8C
	In this case, pmd maps 512 pages, but you only get=5Fpage=5Fbootmem() on=
 the first page.
I think the whole 512 pages should be get=5Fpage=5Fbootmem(), what do you=
 think?
Hi Wu,

Yes, thanks. I will fix it. :)

Thanks. :)

=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help