Thread (7 messages) 7 messages, 3 authors, 2012-11-24

Re: [PATCH 056/493] edac: remove use of __devexit_p

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2012-11-22 18:21:13

On Thu, Nov 22, 2012 at 02:44:51PM +0100, Borislav Petkov wrote:
On Mon, Nov 19, 2012 at 01:20:05PM -0500, Bill Pemberton wrote:
quoted
CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Erm, I don't understand. __devexit_p is defined also for modules not
only for CONFIG_HOTPLUG:

#if defined(MODULE) || defined(CONFIG_HOTPLUG)
#define __devexit_p(x) x
#else
#define __devexit_p(x) NULL
#endif

AFAICT, we cannot remove it yet no?
If MODULE is defined, it defaults to nothing.  And now that
CONFIG_HOTPLUG is always set to Y, this always defaults to nothing.

So it's not set to anything anymore, so it can be removed and then this
whole define chunk can be removed.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help