Re: [PATCH 31/32] perf powerpc: Use uapi/unistd.h to fix build error

On Mon, Nov 19, 2012 at 10:07 AM, Arnaldo Carvalho de Melo
[off-list ref] wrote:

Em Mon, Nov 19, 2012 at 08:29:09AM -0500, Josh Boyer escreveu:

quoted

On Sun, Nov 18, 2012 at 9:29 AM, Arnaldo Carvalho de Melo [off-list ref] wrote:

quoted

From: Sukadev Bhattiprolu <redacted>

quoted

quoted

Use the 'unistd.h' from arch/powerpc/include/uapi to build the perf tool.

This would work for powerpc, but at least s390x and ARM have the same
build issue.  Why would we fix this piecemeal per-arch?

David Howells has a patch that _should_ fix it for all of them at once.
Is there a reason that isn't going in?

David rebased his patch on top of my perf/core branch, I just tested it
and all works as expected, so I'd say he should push that branch
upstream as I can't just cherry pick some csets, it needs a merge that
involves more than just tools/perf AFAIK.

OK...  is perf/core (all 32 commits) headed into 3.7?  Because the perf
build is broken in 3.7-rcX, and we're at the point where Linus gets kind
of picky about what he accepts.  So we'd need your branch and David's to
fix compile issues.  And then we'd need Xiao Guangrong's fixes for 'perf
kvm' to only build on x86.  That's quite a number of fixes we need just
to get perf to compile.  Is someone other than me keeping track of
that?

I would just like people to stop wondering when perf builds on non-x86
architectures will work.

josh