Re: [PATCH] KVM: PPC: bookehv: Allow duplicate calls of DO_KVM macro

On 12.09.2012, at 23:38, Scott Wood [off-list ref] wrote:

On 09/12/2012 01:56 PM, Alexander Graf wrote:

quoted

=20
=20
On 12.09.2012, at 15:18, Mihai Caraman [off-list ref] wrot=

e:

quoted

=20

quoted

The current form of DO_KVM macro restricts its use to one call per input=

quoted

quoted

parameter set. This is caused by kvmppc_resume_\intno\()_\srr1 symbol
definition.
Duplicate calls of DO_KVM are required by distinct implementations of
exeption handlers which are delegated at runtime.

=20
Not sure I understand what you're trying to achieve here. Please elaborat=

e ;)

=20
On 64-bit book3e we compile multiple versions of the TLB miss handlers,
and choose from them at runtime. =20

Why?

Without this patch, we get duplicate
label errors if more than one variant of the same exception uses DO_KVM.

Makes sense. The proposed solution also looks good. Just quickly walk me thr=
ough the reasoning for the runtime check again please.


Alex

=20
-Scott
=20
=20
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html