Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM'

On Thu, 2012-09-06 at 12:44 +1000, Benjamin Herrenschmidt wrote:

On Thu, 2012-09-06 at 10:20 +0800, Fengguang Wu wrote:

quoted

Hi Michael,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
head:   8b64a9dfb091f1eca8b7e58da82f1e7d1d5fe0ad
commit: 474e3d569b63f7275cfec072d7ef7b2ffb8904c8 [11/29] powerpc/pseries: Remove uses of abs_to_virt() and virt_to_abs()
config: powerpc-allmodconfig (attached as .config)

All related error/warning messages:

arch/powerpc/platforms/pseries/iommu.c: In function 'enable_ddw':
arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

Thanks. That seems to be building in my tree oddly, I didn't even have a
warning. Maybe some conditional inclusion ? I will add a commit that
adds an explicit #include of memblock.h

Ok, I see. It's a subtle bisection breakage, the next commit fixes it.
Oh well, I won't rebase for that, but thanks for the heads up.

Cheers,
Ben.