Re: [PATCH 13/25] macintosh/mediabay: add a const qualifier
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-09-05 09:23:43
Also in:
linux-arm-kernel
On Wed, 2012-09-05 at 10:02 +0200, Uwe Kleine-König wrote:
Hello, On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:quoted
On Mon, 2012-07-23 at 11:13 +0200, Uwe Kleine-König wrote:quoted
This prepares *of_device_id.data becoming const. Without this change the following warning would occur: drivers/macintosh/mediabay.c: In function 'media_bay_attach': drivers/macintosh/mediabay.c:589:11: warning: assignment discards 'const' qualifier from pointer target type [enabled by default] Signed-off-by: Uwe Kleine-König <redacted> ---Ack all of these assuming you test built (I didn't)."all" means the two mediabay patches? And yes, they are all built tested.
Yeah, anything powerpc you had in your series, but the two mediabay ones are what I spotted when digging through stuff today :-)
quoted
Do you need me to carry any of this via the powerpc tree ?The patch that adds the const to of_device_id depends[1] on this patch. And the other mediabay is only valid after that const is added. So the easiest is if the series is pulled in one go. Arnd intended to let Linus pull it for 3.6-rc1 but it was missed because of a communication problem. So I intend to get it in during the 3.7 merge window.
Ok, I'm happy for Arnd to carry all of these, I trust his judgement/review for that stuff including for ppc specific bits. Cheers, Ben.
Best regards Uwe [1] it's only a soft depend, because the result is "only" a warning, but still.