-----Original Message-----
From: Shaun Ruffell [mailto:<redacted>]
Sent: Wednesday, September 19, 2012 11:05 AM
To: Xie Shaohui-B21989
Cc: <redacted>; <redacted>;
akpm@linux-foundation.org; avorontsov@mvista.com; linux-
kernel@vger.kernel.org; grant.likely@secretlab.ca
Subject: Re: [PATCH] edac/85xx: fix error handle of mpc85xx_mc_err_probe
=20
On Mon, Sep 17, 2012 at 10:32:59AM +0000, Xie Shaohui-B21989 wrote:
quoted
quoted
-----Original Message-----
From: Shaun Ruffell [mailto:<redacted>]
Sent: Saturday, September 15, 2012 2:22 AM
To: Xie Shaohui-B21989
Cc: <redacted>; <redacted>;
akpm@linux-foundation.org; avorontsov@mvista.com; linux-
kernel@vger.kernel.org; grant.likely@secretlab.ca
Subject: Re: [PATCH] edac/85xx: fix error handle of
mpc85xx_mc_err_probe
On Thu, Sep 13, 2012 at 06:55:29PM +0800, Shaohui Xie wrote:
quoted
Error handle in case of DDR ECC off is wrong, sysfs entries have
not been created, so edac_mc_free which frees a mci instance
should not be called.
Also, free mci's memory in this case.
Jus FYI: I ran into the same error in edac_mc_free() which I
resolved in a slightly different way in some patches I sent
previously. [1]
[1] https://lkml.org/lkml/2012/9/14/475
[S.H] Thanks! I did not aware of this patch when one of my colleague
asked me to have a look at the issue, It could save me some time if I
saw this patch earlier. :(
BTW: seems you are using a different kernel tree with mine.
=20
On the chance that I missing something important: Why do you say I was
running a different kernel tree? I was against 3.6-rc2 when I original
hit the problem.
[S.H] I'm using 3.6-rc4, and some codes in your patch I did not find them i=
n 3.6-rc4.
Best Regards,=20
Shaohui Xie