Re: [PATCH v3 1/2] mmc: Move mmc_delay() to include/linux/mmc/core.h

From
Arnd Bergmann <arnd@arndb.de>
Date
2012-08-10 13:27:56
Also in
linux-mmc
Reply to
Chunhe Lan, 2012-08-10
On Friday 10 August 2012, Chunhe Lan wrote:
quoted hunk ↗ jump to hunk
+static inline void mmc_delay(unsigned int ms)
+{
+	if (ms < 1000 / HZ) {
+		cond_resched();
+		mdelay(ms);
+	} else {
+		msleep(ms);
+	}
+}
I would actually question the point in this function to start with: The
decision whether to call mdelay() or msleep() should only be based on
whether you are allowed to sleep in the caller context. The idea of


	cond_resched();
	mdelay(ms);

sets off alarm bells, and I would always replace that with msleep().

	Arnd
Thread (7 messages) 7 messages, 4 authors, last reply 2012-09-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help