Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie initialization code

On 08/02/2012 10:39 PM, Jia Hongtao-B38951 wrote:

quoted

-----Original Message-----
From: Kumar Gala [mailto:galak@kernel.crashing.org]
Sent: Thursday, August 02, 2012 8:24 PM
To: Jia Hongtao-B38951
Cc: linuxppc-dev@lists.ozlabs.org; Wood Scott-B07421; Li Yang-R58472
Subject: Re: [PATCH V4 3/3] powerpc/fsl-pci: Unify pci/pcie
initialization code

You need to convert all boards to use fsl_pci_init before this patch.
Otherwise we'll end up with PCI getting initialized twice on boards.

- k

If we covert all boards with platform driver in this patch PCI will
be initialized only once without converting all boards to use
fsl_pci_init first. 

Then we'd have to pick apart core changes from board changes when reviewing.

If we convert all boards to use fsl_pci_init before this patch and
convert them to use platform driver again after this patch. Then
between this patch and next pci will be initialized twice too.

Why?  That one patch should both create the platform driver and remove
the init from fsl_pci_init() -- except things like primary bus detection
which has to happen globally.

-Scott