Re: [PATCH -V5 03/13] arch/powerpc: Convert virtual address to vpn

From
Aneesh Kumar K.V <hidden>
Date
2012-08-01 07:23:46
Reply to
Paul Mackerras, 2012-08-01
Paul Mackerras [off-list ref] writes:
On Mon, Jul 30, 2012 at 04:52:09PM +0530, Aneesh Kumar K.V wrote:
quoted
From: "Aneesh Kumar K.V" <redacted>

This patch convert different functions to take virtual page number
instead of virtual address. Virtual page number is virtual address
shifted right by VPN_SHIFT (12) bits. This enable us to have an
address range of upto 76 bits.
Mostly looks good.  I don't think it's necessary to add the
BUILD_BUG_ON and BUG_ON conditions.  I would think a comment next to
the definition saying that VPN_SHIFT can be at most 12 would be
sufficient.
Updated.

Thanks
-aneesh
Thread (27 messages) 27 messages, 2 authors, last reply 2012-08-01
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help