Re: [PATCH v2 1/2] powerpc/mpic: Add Open-PIC global timer document

On Aug 10, 2012, at 12:53 AM, [off-list ref] <Dongsheng.wan=
g@freescale.com> wrote:

From: Wang Dongsheng <redacted>
=20
Add a description of the OPEN-PIC global timer in the OPEN-PIC document.
=20
Moidfy mpic-timer document. 1.Add a TFRR register region. This register
is written by software to report the clocking frequency of the PIC timers=

.

2.Add a device_type. The global timer in line with the OPEN-PIC specifica=

tion.

=20
Signed-off-by: Wang Dongsheng <redacted>
Signed-off-by: Li Yang <redacted>
---
Documentation/devicetree/bindings/open-pic.txt     |   46 +++++++++++++++=

+++++

Let's separate out the open-pic.txt timer binding change into its own patch=
 from the FSL timer binding & dtsi updates.

on/devicetree/bindings/open-pic.txt

g

+  register for the group.  The second is the main timer register bank
+  (GTCCR, GTBCR, GTVPR, GTDR).
+
+- available-ranges: use <start count> style section to define which
+  timer interrupts can be used.  This property is optional; without this=

,

+  all timers within the group can be used.
+
+- interrupts: one interrupt per timer in the group, in order, starting
+  with timer zero.  If available-ranges is present, only the interrupts
+  that correspond to available timers shall be present.
+

If we are going to require device_type property it should be in the binding=
.

Based on the comments in ePAPR, I recommend dropping device_type from the t=
imer binding.

+* Examples
+
+Example 1:
+
+	/* Note that this requires #interrupt-cells to be 4 */
+	timer: timer@010f0 {
+		compatible =3D "open-pic,global-timer";
+		device_type =3D "open-pic";
+		reg =3D <0x010f0 4 0x01100 0x100>;
+
+		/* Another AMP partition is using timer */
+		available-ranges =3D <2 2>;
+
+		interrupts =3D <2 0 3 0
+		              3 0 3 0>;
+	};
+
+Example 2:
+
+	timer: timer@010f0 {
+		compatible =3D "open-pic,global-timer";
+		device_type =3D "open-pic";
+		reg =3D <0x010f0 4 0x01100 0x100>;
+		interrupts =3D <0 0 3 0
+			      1 0 3 0
+			      2 0 3 0
+		              3 0 3 0>;
+	};
+
[1] Power.org (TM) Standard for Embedded Power Architecture (TM) Platform
    Requirements (ePAPR), Version 1.0, July 2008.
    (http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.p=

df)

 b/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt

Why are renaming?.. also use of fsl,global-timer is to generic of a name fo=
r the this.

=20
-- reg : Contains two regions.  The first is the main timer register bank
-  (GTCCRxx, GTBCRxx, GTVPRxx, GTDRxx).  The second is the timer control
+- reg : Contains three regions.  The first is the timer frequency report=

ing

+  register (TFRRx) for the group.  The second is the main timer register
+  bank (GTCCRxx, GTBCRxx, GTVPRxx, GTDRxx).  The third is the timer cont=

rol

pc/boot/dts/fsl/pq3-mpic-timer-B.dtsi

Shouldn't this be:

	compatible =3D "fsl,mpic-global-timer", "open-pic,global-timer";

dts/fsl/pq3-mpic.dtsi

same as above.

+	device_type =3D "open-pic";
+	reg =3D <0x410f0 4 0x41100 0x100 0x41300 4>;
	interrupts =3D <0 0 3 0
		      1 0 3 0
		      2 0 3 0
--=20
1.7.5.1
=20
=20
_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

=20

quoted

a/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
b/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
index df41958..5aafca0 100644

--- a/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/mpic-timer.txt

@@ -1,13 +1,14 @@

* Freescale MPIC timers

Required properties:
-- compatible: "fsl,mpic-global-timer"
+- compatible: "fsl,global-timer"

=20
Why are renaming?.. also use of fsl,global-timer is to generic of a name
for the this.
=20

[Wang Dongsheng] "fsl,global-timer" is generic of a name.