RE: [PATCH] rapidio: apply RX/TX enable to active switch ports only
From: Bounine, Alexandre <hidden>
Date: 2012-08-27 13:02:07
Also in:
lkml
From: Bounine, Alexandre <hidden>
Date: 2012-08-27 13:02:07
Also in:
lkml
On Friday, August 24, 2012 5:04 PM Andrew Morton [off-list ref]
=20 On Tue, 21 Aug 2012 10:23:55 -0400 Alexandre Bounine [off-list ref] wrote: =20quoted
Modify RIO enumeration to apply RX/TX enable operations only to active switch ports. This will leave inactive ports in condition consist=
ent
quoted
with their state.=20 It's unclear (to me) what the effects of this are. Does it fix some user-visible malfunction? Or is it just some nice-to-have thing? Or what? =20
This patch was intended to keep inactive switch ports with inbound and outbound packet transfers disabled to block unexpected packets during hot insertion event. While it does not fix any visible malfunction it was intended to prevent such events in future. =20 Since this patch was published it was brought to my attention that some existing switches may require inbound and outbound ports enabled for inactive ports as well (not spec compliant). Therefore, please remove this patch from your tree. =20
quoted
This patch is applicable to kernel versions starting from v2.6.35.=20 Is that a recommendation that such a backport be performed? If so, please provide the reasoning.