Re: [PATCH v4 2/2] powerpc: Uprobes port to powerpc

From
Oleg Nesterov <oleg@redhat.com>
Date
2012-08-22 15:59:15
Also in
lkml
Reply to
Ananth N Mavinakayanahalli, 2012-08-22
On 08/22, Ananth N Mavinakayanahalli wrote:
quoted hunk ↗ jump to hunk

+int arch_uprobe_analyze_insn(struct arch_uprobe *auprobe, struct mm_struct *mm, unsigned long addr)
+{
+	unsigned int insn;
+
+	if (addr & 0x03)
+		return -EINVAL;
+
+	memcpy(&insn, auprobe->insn, MAX_UINSN_BYTES);
+	if (is_trap(insn))
+		return -ENOTSUPP;
This addresses the only concern I had, thanks.

Once again, I am in no position to review the powerpc code, but
since I made some noise before: I think the patch is fine.

Oleg.
Thread (15 messages) 15 messages, 5 authors, last reply 2012-08-24
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help