Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

2 messages, 2 authors, 2012-08-21 · open the first message on its own page

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

From: Andreas Schwab <hidden>
Date: 2012-08-21 07:14:17

John Stultz [off-list ref] writes:

quoted hunk

@@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
 {
 	tk->xtime_sec += ts->tv_sec;
 	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
+	tk_normalize_xtime(tk);
 }

Yes, that does it.  Failure to normalize is always bad.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

From: John Stultz <hidden>
Date: 2012-08-21 18:15:22

On 08/21/2012 12:14 AM, Andreas Schwab wrote:

John Stultz [off-list ref] writes:

quoted

@@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
  {
  	tk->xtime_sec += ts->tv_sec;
  	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
+	tk_normalize_xtime(tk);
  }

Yes, that does it.  Failure to normalize is always bad.

Great. Thanks for the testing and the bug report! I'll be sending out 
the patch to -tip later today.

thanks
-john

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help