Re: [PATCH 4/8] time: Condense timekeeper.xtime into xtime_sec

Started by Andreas Schwab on Aug 21, 2012 · 2 messages from 2 authors · Last reply Aug 21, 2012

open the first message on its own page

Andreas Schwab

Message details and related content
Open message details and related content
John Stultz [off-list ref] writes:
quoted hunk
@@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
 {
 	tk->xtime_sec += ts->tv_sec;
 	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
+	tk_normalize_xtime(tk);
 }
Yes, that does it.  Failure to normalize is always bad.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

John Stultz replied to Andreas Schwab

Message details and related content
Open message details and related content
On 08/21/2012 12:14 AM, Andreas Schwab wrote:
John Stultz [off-list ref] writes:
quoted
@@ -115,6 +115,7 @@ static void tk_xtime_add(struct timekeeper *tk, const struct timespec *ts)
  {
  	tk->xtime_sec += ts->tv_sec;
  	tk->xtime_nsec += (u64)ts->tv_nsec << tk->shift;
+	tk_normalize_xtime(tk);
  }
Yes, that does it.  Failure to normalize is always bad.
Great. Thanks for the testing and the bug report! I'll be sending out the patch to -tip later today.

thanks
-john
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help