Re: [RFC PATCH v5 12/19] memory-hotplug: introduce new function arch_remove_memory()

At 07/31/2012 08:40 PM, Gerald Schaefer Wrote:

On Mon, 30 Jul 2012 18:35:37 +0800
Wen Congyang [off-list ref] wrote:
=20

quoted

At 07/30/2012 06:23 PM, Heiko Carstens Wrote:

quoted

On Fri, Jul 27, 2012 at 06:32:15PM +0800, Wen Congyang wrote:

quoted

We don't call =5F=5Fadd=5Fpages() directly in the function add=5Fmemor=

y()

quoted

quoted

quoted

because some other architecture related things need to be done
before or after calling =5F=5Fadd=5Fpages(). So we should introduce
a new function arch=5Fremove=5Fmemory() to revert the things
done in arch=5Fadd=5Fmemory().

Note: the function for s390 is not implemented(I don't know how to
implement it for s390).

There is no hardware or firmware interface which could trigger a
hot memory remove on s390. So there is nothing that needs to be
implemented.

Thanks for providing this information.

According to this, arch=5Fremove=5Fmemory() for s390 can just return
-EBUSY.

=20
Yes, but there is a prototype mismatch for arch=5Fremove=5Fmemory() on s3=

90

and also other architectures (u64 vs. unsigned long).
=20
arch/s390/mm/init.c:262: error: conflicting types for
=E2=80=98arch=5Fremove=5Fmemory=E2=80=99 include/linux/memory=5Fhotplug.h=

:88: error: previous

declaration of =E2=80=98arch=5Fremove=5Fmemory=E2=80=99 was here
=20
In memory=5Fhotplug.h you have:
extern int arch=5Fremove=5Fmemory(unsigned long start, unsigned long size=

);

=20
On all archs other than x86 you have:
int arch=5Fremove=5Fmemory(u64 start, u64 size)

Thanks for pointing it out. I will fix it.

Wen Congyang

=20
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/
=20

=