Re: [PATCH 3/6] powerpc/fsl-pci: Determine primary bus by looking for ISA node

On 07/26/2012 09:07 PM, Jia Hongtao-B38951 wrote:

quoted

-----Original Message-----
From: Wood Scott-B07421
Sent: Friday, July 27, 2012 9:34 AM
To: Jia Hongtao-B38951
Cc: Wood Scott-B07421; <redacted>;
galak@kernel.crashing.org; Li Yang-R58472
Subject: Re: [PATCH 3/6] powerpc/fsl-pci: Determine primary bus by
looking for ISA node

On 07/25/2012 09:20 PM, Jia Hongtao-B38951 wrote:

quoted

All this recursion thing I will try another way.

But this is not the same as you did. If we use platform driver probe

function

quoted

will be called more than once. Your function is to find ISA node and

check if

quoted

the parent equal to this PCI controller. My function is to search ISA

under

quoted

each PCI controller.

The result is the same -- "does this PCI controller have an ISA node
under it?"

-Scott

The result is the same but as I said in platform driver probe function will
be called for each PCI controller.

So?  Just because you've got a platform device now doesn't mean you
can't do any early global init.  This has to be done globally, so we can
choose a fallback primary bus if there's no ISA in the system.

-Scott