Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver

On Fri, 2012-07-20 at 09:01 -0500, Seth Jennings wrote:

On 07/20/2012 12:33 AM, Michael Ellerman wrote:

quoted

On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote:

quoted

This patch adds the driver for interacting with the 842
compression accelerator on IBM Power7+ systems.

...

quoted

+struct nx842_slentry {
+	unsigned long ptr; /* Absolute address (use virt_to_abs()) */
/+	unsigned long len;
+};

These days virt_to_abs() is just __pa() - ie. convert to a real address.

Thanks, I'll make that change.

Is it a blocker to the code being pulled in though? I'm
hoping to get this in ASAP for the 3.6 merge window.  As
this isn't a functional defect (I assume __pa() and
virt_to_abs() still achieve the same result), can I get an
OK from you that this isn't a blocker to the code being
accepted?

Sorry I missed your reply. No it's not a blocker, just ugly.

I have sent a series to Ben which removes virt_to_abs() entirely, so
we'll want to make sure we fixup the nx driver before that goes in.

cheers