[PATCH 1/2] powerpc/mm: remove obsolete comment about page size name array

Subsystems: linux for powerpc (32-bit and 64-bit), the rest

STALE5226d

2 messages, 2 authors, 2012-06-15 · open the first message on its own page

[PATCH 1/2] powerpc/mm: remove obsolete comment about page size name array

From: Scott Wood <hidden>
Date: 2012-06-14 23:41:09

The array of names in hugetlbpage.c no longer exists.

Signed-off-by: Scott Wood <redacted>
---
 arch/powerpc/include/asm/mmu.h |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/mmu.h b/arch/powerpc/include/asm/mmu.h
index f014552..a9e9ec6 100644
--- a/arch/powerpc/include/asm/mmu.h
+++ b/arch/powerpc/include/asm/mmu.h
@@ -163,12 +163,7 @@ extern u64 ppc64_rma_size;
  * to think about, feedback welcome. --BenH.
  */
 
-/* There are #define as they have to be used in assembly
- *
- * WARNING: If you change this list, make sure to update the array of
- * names currently in arch/powerpc/mm/hugetlbpage.c or bad things will
- * happen
- */
+/* There are #define as they have to be used in assembly */
 #define MMU_PAGE_4K	0
 #define MMU_PAGE_16K	1
 #define MMU_PAGE_64K	2
-- 
1.7.5.4

Re: [PATCH 1/2] powerpc/mm: remove obsolete comment about page size name array

From: Michael Ellerman <hidden>
Date: 2012-06-15 02:50:29

On Thu, 2012-06-14 at 18:40 -0500, Scott Wood wrote:
quoted hunk
The array of names in hugetlbpage.c no longer exists.

Signed-off-by: Scott Wood <redacted>
---
 arch/powerpc/include/asm/mmu.h |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/include/asm/mmu.h b/arch/powerpc/include/asm/mmu.h
index f014552..a9e9ec6 100644
--- a/arch/powerpc/include/asm/mmu.h
+++ b/arch/powerpc/include/asm/mmu.h
@@ -163,12 +163,7 @@ extern u64 ppc64_rma_size;
  * to think about, feedback welcome. --BenH.
  */
 
-/* There are #define as they have to be used in assembly
- *
- * WARNING: If you change this list, make sure to update the array of
- * names currently in arch/powerpc/mm/hugetlbpage.c or bad things will
- * happen
- */
+/* There are #define as they have to be used in assembly */
     ^^^^^^

Should be "These", I'll fix it up.

cheers
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help