Re: [PATCH 5/5] usb: gadget: composite: parse dt overrides
From: Michal Nazarewicz <hidden>
Date: 2012-06-26 19:18:54
Also in:
linux-devicetree, lkml
On 06/26/2012 09:27 AM, Alexandre Pereira da Silva wrote:quoted
Grab the devicetree node properties to override VendorId, ProductId, bcdDevice, Manucacturer, Product and SerialNumber
Like before, the code looks good to me: Acked-by: Michal Nazarewicz <redacted> Not commenting on the other aspects of the business logic though. On Tue, 26 Jun 2012 20:43:03 +0200, Rob Herring [off-list ref] = wrote:
I'm still confused about what is the order of priority for the 2 possible sources of these values. The way it is written, the DT value =
is
a default, not an override.
They are overwritten by module parameter but they are overwriting anythi=
ng that
composite gadget might be providing.
-- =
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o
..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz=
(o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--