Re: Build regressions/improvements in v3.5-rc3

15 messages, 12 authors, 2012-07-18 · open the first message on its own page

Re: Build regressions/improvements in v3.5-rc3

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2012-06-17 19:57:01

On Sun, Jun 17, 2012 at 9:46 PM, Geert Uytterhoeven
[off-list ref] wrote:
JFYI, when comparing v3.5-rc3 to v3.5-rc2[3], the summaries are:
=C2=A0- build errors: +235/-10
Truckloads of powerpc "Unrecognized opcode" breakage, and

  + arch/mips/include/asm/bitops.h: error: static declaration of 'fls'
follows non-static declaration:  =3D> 615:50
  + include/asm-generic/bitops/fls64.h: error: static declaration of
'fls64' follows non-static declaration:  =3D> 26:81, 18:81
  + include/linux/bitops.h: error: conflicting types for 'fls_long':  =3D> =
160:55

various mips

  + drivers/edac/mpc85xx_edac.c: error: too few arguments to function
'edac_mc_alloc':  =3D> 983:90

powerpc-randconfig

  + drivers/net/ethernet/dlink/de600.c: error: expected expression
before 'do':  =3D> 146:2, 301:3, 210:3, 150:2, 468:2, 404:2, 208:3,
495:3, 328:2, 138:2, 499:2, 217:3, 417:2, 136:2, 300:3, 464:2, 501:2,
493:2, 206:2, 216:3, 254:4, 350:2, 196:3, 137:2, 405:2, 463:2
  + drivers/scsi/pcmcia/sym53c500_cs.c: error: expected expression
before 'do':  =3D> 453:4, 434:4, 574:2, 371:2
  + drivers/scsi/qlogicfas408.c: error: expected expression before
'do':  =3D> 234:2, 221:2, 312:3, 583:2, 535:2, 324:3, 85:2, 406:2,
316:5, 569:9, 89:3, 230:2, 546:2
  + drivers/staging/wlags49_h2/hcf.c: error: expected expression
before 'do':  =3D> 3375:4, 3592:3, 4378:3, 1135:3, 1203:3, 3593:3,
4731:3, 3653:3, 704:4, 3802:3, 1150:2, 1209:2, 3645:10, 4178:2,
3699:5, 3007:5, 4033:2, 787:3, 2646:4, 1190:2, 3797:3, 717:3, 2630:3,
4732:3, 703:4, 3582:2, 751:5, 2629:3, 755:5, 3507:3, 1153:2, 750:5,
3057:4, 781:4, 2654:4, 3700:5
  + drivers/staging/wlags49_h25/../wlags49_h2/hcf.c: error: expected
expression before 'do':  =3D> 3375:4, 3592:3, 4378:3, 1135:3, 1203:3,
3593:3, 4731:3, 3653:3, 704:4, 3802:3, 1150:2, 1209:2, 3645:10,
3699:5, 4033:2, 787:3, 2646:4, 1190:2, 717:3, 2630:3, 4732:3, 703:4,
3582:2, 751:5, 2629:3, 755:5, 3507:3, 1153:2, 750:5, 3057:4, 781:4,
2654:4, 3700:5

sh-allyesconfig/sh-allmodconfig

  + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implicit
declaration of function 'pci_iomap'
[-Werror=3Dimplicit-function-declaration]:  =3D> 90:3
  + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implicit
declaration of function 'pci_iounmap'
[-Werror=3Dimplicit-function-declaration]:  =3D> 142:2

xtensa

  + error: "__ashrdi3" [fs/ntfs/ntfs.ko] undefined!:  =3D> N/A
  + error: "__lshrdi3" [fs/ntfs/ntfs.ko] undefined!:  =3D> N/A

sh4/landisk_defconfig

  + error: "__ashrdi3" [fs/xfs/xfs.ko] undefined!:  =3D> N/A
  + error: "__lshrdi3" [drivers/mtd/mtd.ko] undefined!:  =3D> N/A
  + error: "__lshrdi3" [fs/xfs/xfs.ko] undefined!:  =3D> N/A

sh4/titan_defconfig

  + error: No rule to make target include/config/auto.conf:  =3D> N/A

x86_64-randconfig

  + kernel/sys.c: error: 'mmap_min_addr' undeclared (first use in this
function):  =3D> 1864:34, 1864:2
  + security/security.c: error: 'BDI_CAP_EXEC_MAP' undeclared (first
use in this function):  =3D> 688:16, 688:3
  + security/security.c: error: dereferencing pointer to incomplete
type:  =3D> 687:36

sh-allyesconfig/sh-allmodconfig/sh-randconfig

Gr{oetje,eeting}s,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds

Re: Build regressions/improvements in v3.5-rc3

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2012-06-17 21:53:51

On Sun, 2012-06-17 at 21:56 +0200, Geert Uytterhoeven wrote:
Truckloads of powerpc "Unrecognized opcode" breakage, and
Where ? The boot wrappers again ?

Cheers,
Ben.

Re: Build regressions/improvements in v3.5-rc3

From: Kim Phillips <hidden>
Date: 2012-06-18 20:30:07

On Sun, 17 Jun 2012 21:56:59 +0200
Geert Uytterhoeven [off-list ref] wrote:
  + drivers/edac/mpc85xx_edac.c: error: too few arguments to function
'edac_mc_alloc':  => 983:90

powerpc-randconfig
fixed in linux-next commit b9bc5dd, should have been upstreamed by
now [1] - Mauro?

Kim

[1] http://marc.info/?l=linux-edac&m=133942731507920&w=2

Re: Build regressions/improvements in v3.5-rc3

From: Mauro Carvalho Chehab <hidden>
Date: 2012-06-18 20:35:21

Em 18-06-2012 17:27, Kim Phillips escreveu:
On Sun, 17 Jun 2012 21:56:59 +0200
Geert Uytterhoeven [off-list ref] wrote:
quoted
   + drivers/edac/mpc85xx_edac.c: error: too few arguments to function
'edac_mc_alloc':  => 983:90

powerpc-randconfig
fixed in linux-next commit b9bc5dd, should have been upstreamed by
now [1] - Mauro?
Just sent it a few mins ago. I was waiting for Linus to return back 
from his trip.

Regards,
Mauro
Kim

[1] http://marc.info/?l=linux-edac&m=133942731507920&w=2

Re: Build regressions/improvements in v3.5-rc3

From: Paul Mundt <hidden>
Date: 2012-06-20 04:00:12

On Sun, Jun 17, 2012 at 09:56:59PM +0200, Geert Uytterhoeven wrote:
On Sun, Jun 17, 2012 at 9:46 PM, Geert Uytterhoeven
[off-list ref] wrote:
quoted
JFYI, when comparing v3.5-rc3 to v3.5-rc2[3], the summaries are:
??- build errors: +235/-10
Truckloads of powerpc "Unrecognized opcode" breakage, and
That was my fault, should be fixed up by 2603efa31a.
  + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implicit
declaration of function 'pci_iomap'
[-Werror=implicit-function-declaration]:  => 90:3
  + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implicit
declaration of function 'pci_iounmap'
[-Werror=implicit-function-declaration]:  => 142:2
Not sure about this one, it should find everything alright via:

	linux/io.h -> asm/io.h -> asm-generic/iomap.h -> asm-generic/pci_iomap.h

in the case that PCI is enabled. None of allyesconfig/modconfig enable
PCI for me though, so I'm unsure of how you got in to this configuration
to begin with?
xtensa

  + error: "__ashrdi3" [fs/ntfs/ntfs.ko] undefined!:  => N/A
  + error: "__lshrdi3" [fs/ntfs/ntfs.ko] undefined!:  => N/A

sh4/landisk_defconfig

  + error: "__ashrdi3" [fs/xfs/xfs.ko] undefined!:  => N/A
  + error: "__lshrdi3" [drivers/mtd/mtd.ko] undefined!:  => N/A
  + error: "__lshrdi3" [fs/xfs/xfs.ko] undefined!:  => N/A
These seem to be the same issue on both platforms, EXPORT_SYMBOL()
doesn't work from lib-y. While it's straightforward to fix, I'm not able
to reproduce __lshrdi3/__ashrdi3 references in any of the above, which
compiler are you using?

[PATCH] MIPS: fix bug.h MIPS build regression

From: Yoichi Yuasa <hidden>
Date: 2012-06-20 06:28:18

Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.

  CC      arch/mips/kernel/machine_kexec.o
In file included from include/linux/kernel.h:20:0,
                 from include/asm-generic/bug.h:35,
                 from /home/yuasa/src/linux/kernel/git/linux-2.6/arch/mips/include/asm/bug.h:41,
                 from /home/yuasa/src/linux/kernel/git/linux-2.6/arch/mips/include/asm/bitops.h:20,
                 from include/linux/bitops.h:22,
                 from include/linux/signal.h:38,
                 from include/linux/elfcore.h:5,
                 from include/linux/kexec.h:60,
                 from arch/mips/kernel/machine_kexec.c:9:
include/linux/log2.h: In function '__ilog2_u32':
include/linux/log2.h:34:2: error: implicit declaration of function 'fls' [-Werror=implicit-function-declaration]
include/linux/log2.h: In function '__ilog2_u64':
include/linux/log2.h:42:2: error: implicit declaration of function 'fls64' [-Werror=implicit-function-declaration]
include/linux/log2.h: In function '__roundup_pow_of_two':
include/linux/log2.h:63:2: error: implicit declaration of function 'fls_long' [-Werror=implicit-function-declaration]
In file included from include/linux/bitops.h:22:0,
                 from include/linux/signal.h:38,
                 from include/linux/elfcore.h:5,
                 from include/linux/kexec.h:60,
                 from arch/mips/kernel/machine_kexec.c:9:
/home/yuasa/src/linux/kernel/git/linux-2.6/arch/mips/include/asm/bitops.h: At top level:
/home/yuasa/src/linux/kernel/git/linux-2.6/arch/mips/include/asm/bitops.h:615:19: error: static declaration of 'fls' follows non-static declaration
include/linux/log2.h:34:9: note: previous implicit declaration of 'fls' was here
In file included from /home/yuasa/src/linux/kernel/git/linux-2.6/arch/mips/include/asm/bitops.h:651:0,
                 from include/linux/bitops.h:22,
                 from include/linux/signal.h:38,
                 from include/linux/elfcore.h:5,
                 from include/linux/kexec.h:60,
                 from arch/mips/kernel/machine_kexec.c:9:
include/asm-generic/bitops/fls64.h:18:28: error: static declaration of 'fls64' follows non-static declaration
include/linux/log2.h:42:9: note: previous implicit declaration of 'fls64' was here
In file included from include/linux/signal.h:38:0,
                 from include/linux/elfcore.h:5,
                 from include/linux/kexec.h:60,
                 from arch/mips/kernel/machine_kexec.c:9:
include/linux/bitops.h:160:24: error: conflicting types for 'fls_long'
include/linux/log2.h:63:16: note: previous implicit declaration of 'fls_long' was here
cc1: all warnings being treated as errors

make[2]: *** [arch/mips/kernel/machine_kexec.o] Error 1

Signed-off-by: Yoichi Yuasa <redacted>
---
 arch/mips/include/asm/bitops.h |    1 -
 arch/mips/include/asm/io.h     |    1 +
 2 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/include/asm/bitops.h b/arch/mips/include/asm/bitops.h
index 2e1ad4c..82ad35c 100644
--- a/arch/mips/include/asm/bitops.h
+++ b/arch/mips/include/asm/bitops.h
@@ -17,7 +17,6 @@
 #include <linux/irqflags.h>
 #include <linux/types.h>
 #include <asm/barrier.h>
-#include <asm/bug.h>
 #include <asm/byteorder.h>		/* sigh ... */
 #include <asm/cpu-features.h>
 #include <asm/sgidefs.h>
diff --git a/arch/mips/include/asm/io.h b/arch/mips/include/asm/io.h
index 37a8379..100f9a3 100644
--- a/arch/mips/include/asm/io.h
+++ b/arch/mips/include/asm/io.h
@@ -17,6 +17,7 @@
 #include <linux/types.h>
 
 #include <asm/addrspace.h>
+#include <asm/bug.h>
 #include <asm/byteorder.h>
 #include <asm/cpu.h>
 #include <asm/cpu-features.h>
-- 
1.7.0.4

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: John Crispin <john@phrozen.org>
Date: 2012-06-20 07:10:14

On 20/06/12 08:27, Yoichi Yuasa wrote:
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.
Hi Yoichi,

I stumbled across the same build regression last night and came up with
almost the same fix :-)

Tested-by: John Crispin <redacted>

Thanks,
John

Re: Build regressions/improvements in v3.5-rc3

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2012-06-20 08:02:54

On Wed, Jun 20, 2012 at 5:59 AM, Paul Mundt [off-list ref] wrote:
On Sun, Jun 17, 2012 at 09:56:59PM +0200, Geert Uytterhoeven wrote:
quoted
On Sun, Jun 17, 2012 at 9:46 PM, Geert Uytterhoeven
[off-list ref] wrote:
quoted
JFYI, when comparing v3.5-rc3 to v3.5-rc2[3], the summaries are:
??- build errors: +235/-10
Truckloads of powerpc "Unrecognized opcode" breakage, and
That was my fault, should be fixed up by 2603efa31a.
quoted
=C2=A0 + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implic=
it
quoted
declaration of function 'pci_iomap'
[-Werror=3Dimplicit-function-declaration]: =C2=A0=3D> 90:3
=C2=A0 + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implic=
it
quoted
declaration of function 'pci_iounmap'
[-Werror=3Dimplicit-function-declaration]: =C2=A0=3D> 142:2
Not sure about this one, it should find everything alright via:

=C2=A0 =C2=A0 =C2=A0 =C2=A0linux/io.h -> asm/io.h -> asm-generic/iomap.h =
-> asm-generic/pci_iomap.h
in the case that PCI is enabled. None of allyesconfig/modconfig enable
PCI for me though, so I'm unsure of how you got in to this configuration
to begin with?
These were xtensa, not sh.

The ones above ("error: expected expression before 'do'") were sh.
quoted
=C2=A0 + error: "__ashrdi3" [fs/ntfs/ntfs.ko] undefined!: =C2=A0=3D> N/A
=C2=A0 + error: "__lshrdi3" [fs/ntfs/ntfs.ko] undefined!: =C2=A0=3D> N/A

sh4/landisk_defconfig

=C2=A0 + error: "__ashrdi3" [fs/xfs/xfs.ko] undefined!: =C2=A0=3D> N/A
=C2=A0 + error: "__lshrdi3" [drivers/mtd/mtd.ko] undefined!: =C2=A0=3D> =
N/A
quoted
=C2=A0 + error: "__lshrdi3" [fs/xfs/xfs.ko] undefined!: =C2=A0=3D> N/A
These seem to be the same issue on both platforms, EXPORT_SYMBOL()
doesn't work from lib-y. While it's straightforward to fix, I'm not able
to reproduce __lshrdi3/__ashrdi3 references in any of the above, which
compiler are you using?
http://kisskb.ellerman.id.au/kisskb/buildresult/6543287/ says
sh4-linux-gcc (GCC) 4.6.3

Gr{oetje,eeting}s,

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0=C2=A0 =C2=A0=C2=A0 -- Linus Torvalds

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: Sergei Shtylyov <hidden>
Date: 2012-06-20 10:41:25

Hello.

On 20-06-2012 10:27, Yoichi Yuasa wrote:
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578
   Please also specify the summary of that commit in parens.
breaks all MIPS builds.
[...]
Signed-off-by: Yoichi Yuasa<redacted>
WBR, Sergei

Re: Build regressions/improvements in v3.5-rc3

From: Giuseppe CAVALLARO <hidden>
Date: 2012-06-20 12:51:30

Hello Paul

On 6/20/2012 5:59 AM, Paul Mundt wrote:
On Sun, Jun 17, 2012 at 09:56:59PM +0200, Geert Uytterhoeven wrote:
quoted
On Sun, Jun 17, 2012 at 9:46 PM, Geert Uytterhoeven
[off-list ref] wrote:
quoted
JFYI, when comparing v3.5-rc3 to v3.5-rc2[3], the summaries are:
??- build errors: +235/-10
Truckloads of powerpc "Unrecognized opcode" breakage, and
That was my fault, should be fixed up by 2603efa31a.
quoted
  + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implicit
declaration of function 'pci_iomap'
[-Werror=implicit-function-declaration]:  => 90:3
  + drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c: error: implicit
declaration of function 'pci_iounmap'
[-Werror=implicit-function-declaration]:  => 142:2
Not sure about this one, it should find everything alright via:

	linux/io.h -> asm/io.h -> asm-generic/iomap.h -> asm-generic/pci_iomap.h

in the case that PCI is enabled. None of allyesconfig/modconfig enable
PCI for me though, so I'm unsure of how you got in to this configuration
to begin with?
Trying to reproduce the problem, I've also re-built the mainstream
kernel 3.5-rc3 for se7724_defconfig platform plus the stmmac (pltf and
pci) but all compiles fine.

I've also verified that there is the 33d5e332b9c5 commit that is the
latest one discussed/tested/committed in the network mailing list.

Can you tell me how to reproduce the problem? How can I help?

Pls let me know,
Peppe

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: Ralf Baechle <hidden>
Date: 2012-06-20 16:13:14

On Wed, Jun 20, 2012 at 03:27:59PM +0900, Yoichi Yuasa wrote:
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.
Thanks, fix applied.

  Ralf

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: David Daney <hidden>
Date: 2012-06-22 17:54:16

On 06/20/2012 09:12 AM, Ralf Baechle wrote:
On Wed, Jun 20, 2012 at 03:27:59PM +0900, Yoichi Yuasa wrote:
quoted
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.
Thanks, fix applied.
Where was it applied?

It doesn't show up in linux-next for 20120622, which is where it is needed.

David Daney

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2012-07-16 19:27:15

On Fri, Jun 22, 2012 at 7:54 PM, David Daney [off-list ref] wrote:
On 06/20/2012 09:12 AM, Ralf Baechle wrote:
quoted
On Wed, Jun 20, 2012 at 03:27:59PM +0900, Yoichi Yuasa wrote:
quoted
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.

Thanks, fix applied.
Where was it applied?

It doesn't show up in linux-next for 20120622, which is where it is needed.
It's also desperately needed in mainline for 3.5.

Ralf?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2012-07-18 08:35:52

On Mon, Jul 16, 2012 at 9:27 PM, Geert Uytterhoeven
[off-list ref] wrote:
On Fri, Jun 22, 2012 at 7:54 PM, David Daney [off-list ref] wrote:
quoted
On 06/20/2012 09:12 AM, Ralf Baechle wrote:
quoted
On Wed, Jun 20, 2012 at 03:27:59PM +0900, Yoichi Yuasa wrote:
quoted
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.

Thanks, fix applied.
Where was it applied?

It doesn't show up in linux-next for 20120622, which is where it is needed.
It's also desperately needed in mainline for 3.5.

Ralf?
Andrew? This prevents any green MIPS builds.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] MIPS: fix bug.h MIPS build regression

From: Andrew Morton <akpm@linux-foundation.org>
Date: 2012-07-18 21:07:43

On Wed, 18 Jul 2012 10:35:46 +0200
Geert Uytterhoeven [off-list ref] wrote:
On Mon, Jul 16, 2012 at 9:27 PM, Geert Uytterhoeven
[off-list ref] wrote:
quoted
On Fri, Jun 22, 2012 at 7:54 PM, David Daney [off-list ref] wrote:
quoted
On 06/20/2012 09:12 AM, Ralf Baechle wrote:
quoted
On Wed, Jun 20, 2012 at 03:27:59PM +0900, Yoichi Yuasa wrote:
quoted
Commit: 3777808873b0c49c5cf27e44c948dfb02675d578 breaks all MIPS builds.

Thanks, fix applied.
Where was it applied?

It doesn't show up in linux-next for 20120622, which is where it is needed.
It's also desperately needed in mainline for 3.5.

Ralf?
Andrew? This prevents any green MIPS builds.
The patch is already in linux-next via Ralf's tree.

Perhaps he nodded off - I'll send it at Linus right now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help