RE: [PATCH 1/2] powerpc/watchdog: move booke watchdog param related code to prom.c

quoted

quoted

quoted

quoted

.org] On Behalf Of Shaohui Xie
Sent: Tuesday, May 08, 2012 11:37 AM
To: linux-watchdog@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
Cc: Xie Shaohui-B21989
Subject: [PATCH 1/2] powerpc/watchdog: move booke watchdog param
related code to prom.c

Currently, BOOKE watchdog code for checking "wdt" and "wdt_period"
is in setup_32.c, it cannot be used in 64-bit, so move it to a
common place prom.c, which will be shared by 32-bit and 64-bit.

Also, replace the simple_strtoul with kstrtol.

Signed-off-by: Shaohui Xie <redacted>
---
 arch/powerpc/kernel/prom.c     |   27 +++++++++++++++++++++++++++
 arch/powerpc/kernel/setup_32.c |   24 ------------------------
 2 files changed, 27 insertions(+), 24 deletions(-)

Is not setup-common.c is better place to move this?

Move out from setup_32.c does not mean it have to go into
setup-common.c, I need better reason to do this.

What I think that setup_32.c is for 32 bit, setup_64.c is for 64 bit
and setup-common.c is for both.

I am not saying that you move this to setup-common.c. I am asking why
you have not used setup-common.c ? I am ok even with prom.c.

[Xie Shaohui] I'm not a fan of prom.c, I did this because I see same kind=

 of

early parameters checking is did in this file only, so I thought maybe I =

should

put them together. And seems setup-common.c is not the place to do comman=

d line

checking (I'm not sure about this).
=20

Ok, so you are also not sure.
Let us see what other guys things of this.

Thanks
-Bharat