Re: [PATCH 1/3] of: Add prefix parameter to of_modalias_node().

Cool, thanks.

g.

On Tue, May 22, 2012 at 4:49 PM, David Daney [off-list ref] wrote:

On 05/22/2012 01:09 PM, Grant Likely wrote:

quoted

On Tue, May 22, 2012 at 1:45 PM, David Daney[off-list ref]
=A0wrote:

quoted

On 05/19/2012 11:08 PM, Grant Likely wrote:

quoted

On Sat, 19 May 2012 23:54:36 -0600, Grant
Likely[off-list ref] =A0 =A0wrote:

quoted

On Fri, 11 May 2012 15:05:21 -0700, David Daney<ddaney.cavm@gmail.com=

quoted

quoted

quoted

quoted

=A0wrote:

quoted

From: David Daney<redacted>

When generating MODALIASes, it is convenient to add things like "spi=

:"

quoted

quoted

quoted

quoted

quoted

or "i2c:" to the front of the strings. =A0This allows the standard
modprobe to find the right driver when automatically populating bus
children from the device tree structure.

Add a prefix parameter, and adjust callers. =A0For
of_register_spi_devices() use the "spi:" prefix.

Signed-off-by: David Daney<redacted>

Applied, thanks. =A0Some notes below...

Wait... why is this necessary?

Because in of_register_spi_devices() in of_spi.c, you do:

=A0 =A0 =A0 =A0request_module(spi->modalias);

The string passed to request_module() must have the "spi:" prefix.

How about modifying the call to request_module() to include the prefix
also? =A0I think that would be a simpler change overall. =A0Would that
work?

It seems to. =A0I just sent such a patch in a new thread.

David Daney

--=20
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.