Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

On 2012年05月03日 16:09, Benjamin Herrenschmidt wrote:

On Thu, 2012-05-03 at 14:59 +0800, Wang Sheng-Hui wrote:

quoted

On 2012年05月03日 14:33, Wang Sheng-Hui wrote:

quoted

if (unlikely(irq_happened != PACA_IRQ_HARD_DIS))

quoted

		__hard_irq_disable();

I have commented out the 2 lines.

No, Only comment the test, you must absolutely leave the
__hard_irq_disable() call ! That's the whole point of the test, make
sure we unconditionally disable to see if that fixes the problem, in
which case that will tell us that we somewhere accidentally leave
irq_happened set to 0x01 while irqs are hard enabled.

It can work.
My system has been running for about 15 hours without crash.

Cheers,
Ben.