Re: [EDAC PATCH v13 2/7] edac: move dimm properties to struct dimm_info

From
Borislav Petkov <hidden>
Date
2012-04-26 14:27:02
Reply to
Mauro Carvalho Chehab, 2012-04-16
On Mon, Apr 16, 2012 at 05:12:08PM -0300, Mauro Carvalho Chehab wrote:
On systems based on chip select rows, all channels need to use memories
with the same properties, otherwise the memories on channels A and B
won't be recognized.

However, such assumption is not true for all types of memory
controllers.

Controllers for FB-DIMM's don't have such requirements.

Also, modern Intel controllers seem to be capable of handling such
differences.

So, we need to get rid of storing the DIMM information into a per-csrow
data, storing it, instead at the right place.

The first step is to move grain, mtype, dtype and edac_mode to the
per-dimm struct.

Reviewed-by: Aristeu Rozanski <redacted>
Cc: Doug Thompson <redacted>
Cc: Borislav Petkov <redacted>
Cc: Mark Gross <redacted>
Cc: Jason Uhlenkott <redacted>
Cc: Tim Small <redacted>
Cc: Ranganathan Desikan <redacted>
Cc: "Arvind R." <redacted>
Cc: Olof Johansson <redacted>
Cc: Egor Martovetsky <egor@pasemi.com>
Cc: Chris Metcalf <redacted>
Cc: Michal Marek <redacted>
Cc: Jiri Kosina <redacted>
Cc: Joe Perches <joe@perches.com>
Cc: Dmitry Eremin-Solenikov <redacted>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Hitoshi Mitake <redacted>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: James Bottomley <redacted>
Cc: "Niklas Söderlund" <redacted>
Cc: Shaohui Xie <redacted>
Cc: Josh Boyer <redacted>
Cc: Mike Williams <redacted>
Cc: <redacted>
Signed-off-by: Mauro Carvalho Chehab <redacted>
For the amd64_edac and core changes:

Reviewed-by: Borislav Petkov <redacted>

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
Thread (2 messages) 2 messages, 2 authors, last reply 2012-04-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help