Re: [PATCH] powerpc/85xx: Add back condition for smp
From: Kumar Gala <hidden>
Date: 2012-04-18 13:37:36
On Apr 17, 2012, at 4:39 PM, York Sun wrote:
The timebase synchronization is only necessary if we need to reset a
separate core. Currently only KEXEC and CPU hotplug require resetting
a single core. The following code should be in the condition of
CONFIG_KEXEC or CONFIG_HOTPLUG_CPU
=20
.give_timebase =3D smp_generic_give_timebase,
.take_timebase =3D smp_generic_take_timebase,This doesn't explain why you are putting the #ifdef back, only under = what conditions it applies.
quoted hunk ↗ jump to hunk
=20 Signed-off-by: York Sun <redacted> Acked-by: Li Yang <redacted> --- arch/powerpc/platforms/85xx/smp.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) =20diff --git a/arch/powerpc/platforms/85xx/smp.c =
b/arch/powerpc/platforms/85xx/smp.c
quoted hunk ↗ jump to hunk
index 56942af..868c6d7 100644--- a/arch/powerpc/platforms/85xx/smp.c +++ b/arch/powerpc/platforms/85xx/smp.c@@ -192,8 +192,10 @@ struct smp_ops_t smp_85xx_ops =3D {.cpu_disable =3D generic_cpu_disable, .cpu_die =3D generic_cpu_die, #endif +#if defined(CONFIG_KEXEC) || defined(CONFIG_HOTPLUG_CPU) .give_timebase =3D smp_generic_give_timebase, .take_timebase =3D smp_generic_take_timebase, +#endif }; =20 #ifdef CONFIG_KEXEC --=20 1.7.0.4 =20 =20 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev